Attention is currently required from: Arne Schwabe, Frank Lichtenheld, Răzvan Cojocaru.
chugly has posted comments on this change by chugly. ( https://gerrit.openvpn.net/c/openvpn/+/1946?usp=email ) Change subject: tests: add unit tests for route.c ...................................................................... Patch Set 4: (1 comment) File tests/unit_tests/openvpn/test_route.c: https://gerrit.openvpn.net/c/openvpn/+/1946/comment/4ff9991d_6588e136?usp=email : PS4, Line 106: * use to tell "host route" from "network route" > Do they? In route.c I see: […] You're right, that comment was wrong, and I've cut it down to what the function does. The -1 goes back to the initial import, so there's no recorded reason for it. Of the two callers, the interactive service maps it back to 32, and --server treats it as an invalid netmask, so a /32 server network is rejected. I kept the assertion because that rejection depends on it. The commit message said the same wrong thing; that's fixed too. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9085c55a7efefd31839b00ec8ec9a6f085574dde Gerrit-Change-Number: 1946 Gerrit-PatchSet: 4 Gerrit-Owner: chugly <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2026 06:36:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
