Attention is currently required from: chugly, plaisthos, razvanc.

flichtenheld has posted comments on this change by chugly. ( 
http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email )

Change subject: tests: add unit tests for route.c
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

Patchset:

PS3:
Please fix the builds


File CMakeLists.txt:

http://gerrit.openvpn.net/c/openvpn/+/1946/comment/f9b10e32_c8cea815?usp=email :
PS3, Line 947:             tests/unit_tests/openvpn/mock_get_random.c
breaks the windows builds


http://gerrit.openvpn.net/c/openvpn/+/1946/comment/7d4a99eb_c9821be4?usp=email :
PS3, Line 1007:             tests/unit_tests/openvpn/mock_get_random.c
Why was this removed? It broke the build.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9085c55a7efefd31839b00ec8ec9a6f085574dde
Gerrit-Change-Number: 1946
Gerrit-PatchSet: 3
Gerrit-Owner: chugly <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-Reviewer: razvanc <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: chugly <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Mon, 28 Sep 2026 10:17:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to