Attention is currently required from: Arne Schwabe, Frank Lichtenheld, Răzvan 
Cojocaru.

chugly has posted comments on this change by chugly. ( 
https://gerrit.openvpn.net/c/openvpn/+/1946?usp=email )

Change subject: tests: add unit tests for route.c
......................................................................


Patch Set 3:

(2 comments)

File CMakeLists.txt:

https://gerrit.openvpn.net/c/openvpn/+/1946/comment/d385ed35_ce6350aa?usp=email 
:
PS3, Line 947:             tests/unit_tests/openvpn/cert_data.h
> breaks the windows builds
Fixed in PS4. Those two mock_get_random.c removals were never meant to be part 
of this change.


https://gerrit.openvpn.net/c/openvpn/+/1946/comment/5dd9864c_2536edf7?usp=email 
:
PS3, Line 1007:     if (TARGET test_pkcs11)
> Why was this removed? It broke the build.
Fixed in PS4. Those two mock_get_random.c removals were never meant to be part 
of this change.



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/1946?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9085c55a7efefd31839b00ec8ec9a6f085574dde
Gerrit-Change-Number: 1946
Gerrit-PatchSet: 3
Gerrit-Owner: chugly <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Frank Lichtenheld <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Răzvan Cojocaru <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Frank Lichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 06 Oct 2026 06:36:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Lichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to