Attention is currently required from: Frank Lichtenheld, chugly, plaisthos.
Răzvan Cojocaru has posted comments on this change by chugly. ( https://gerrit.openvpn.net/c/openvpn/+/1946?usp=email ) Change subject: tests: add unit tests for route.c ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File tests/unit_tests/openvpn/test_route.c: https://gerrit.openvpn.net/c/openvpn/+/1946/comment/41a315c3_8e66aa9f?usp=email : PS4, Line 106: * use to tell "host route" from "network route" Do they? In route.c I see: ``` route_message_t msg = { .header = { (add ? msg_add_route : msg_del_route), sizeof(route_message_t), 0 }, .family = AF_INET, .prefix.ipv4.s_addr = htonl(r->network), .gateway.ipv4.s_addr = htonl(r->gateway), .iface = { .index = if_index, .name = "" }, .metric = (r->flags & RT_METRIC_DEFINED) ? r->metric : -1 }; netmask_to_netbits(r->network, r->netmask, &msg.prefix_len); if (msg.prefix_len == -1) { msg.prefix_len = 32; } return do_route_service(add, &msg, sizeof(msg), tt->options.msg_channel); ``` Or in helper.c: ``` status = netmask_to_netbits(o->server_network, o->server_netmask, &netbits); if (!status) { msg(M_USAGE, "--server directive network/netmask combination is invalid"); } if (netbits < 0) { msg(M_USAGE, "--server directive netmask is invalid"); } ``` These don't look like `-1` is used "to tell a host route from a network route". -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9085c55a7efefd31839b00ec8ec9a6f085574dde Gerrit-Change-Number: 1946 Gerrit-PatchSet: 4 Gerrit-Owner: chugly <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: chugly <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 06:09:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
