Hi Ragnar,

This change works.

The line:

//Make the half format work against openEXR libs
// #define OPENEXR_DLL

Is not appropriate for cross platform build, so I've added an #ifdef
_WIN32 #endif around it.

Could you do an svn update and let me know if this works.
Robert.


On Thu, Nov 27, 2008 at 7:40 AM, Ragnar Hammarqvist
<[EMAIL PROTECTED]> wrote:
> I do not get the same error in my compiler (vc2009), so I don't know if these 
> actually fix your errors. But if I read you error right the 
> C_Ostream::operator = is not implemented in Imf. So my fix is to simply 
> replace the = by calling the constructor directly.
>
> Pleas let me know if this fix did not work. If so I can look it over with 
> other compilers later this weak when I have more time.
>
> Regards Ragnar
>
> -----Ursprungligt meddelande-----
> Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För Robert Osfield
> Skickat: den 26 november 2008 13:39
> Till: OpenSceneGraph Submissions
> Ämne: Re: [osg-submissions] EXR read and writer
>
> HI Ragnar et al,
>
> I have had a bash at porting the code, but it's not complete yet.
> I've written an CMakeModules/FindOpenEXR.cmake, wired up the CMakefile but 
> stumbled on the an error:
>
> [ 77%] Building CXX object
> src/osgPlugins/exr/CMakeFiles/osgdb_exr.dir/ReaderWriterEXR.o
> /usr/include/OpenEXR/ImfIO.h: In copy constructor 'C_IStream::C_IStream(const 
> C_IStream&)':
> /usr/include/OpenEXR/ImfIO.h:113: error: 'Imf::IStream::IStream(const 
> Imf::IStream&)' is private
> /home/robert/OpenSceneGraph/src/osgPlugins/exr/ReaderWriterEXR.cpp:33:
> error: within this context
> /home/robert/OpenSceneGraph/src/osgPlugins/exr/ReaderWriterEXR.cpp: In 
> function 'unsigned char* exr_load(std::istream&, int*, int*, int*, unsigned 
> int*)':
> /home/robert/OpenSceneGraph/src/osgPlugins/exr/ReaderWriterEXR.cpp:97:
> note: synthesized method 'C_IStream::C_IStream(const C_IStream&)'
> first required here
> /usr/include/OpenEXR/ImfIO.h: In copy constructor 'C_OStream::C_OStream(const 
> C_OStream&)':
> /usr/include/OpenEXR/ImfIO.h:176: error: 'Imf::OStream::OStream(const 
> Imf::OStream&)' is private
> /home/robert/OpenSceneGraph/src/osgPlugins/exr/ReaderWriterEXR.cpp:60:
> error: within this context
> /home/robert/OpenSceneGraph/src/osgPlugins/exr/ReaderWriterEXR.cpp: In member 
> function 'bool ReaderWriterEXR::writeEXRStream(const
> osg::Image&, std::ostream&, const std::string&) const':
> /home/robert/OpenSceneGraph/src/osgPlugins/exr/ReaderWriterEXR.cpp:271:
> note: synthesized method 'C_OStream::C_OStream(const C_OStream&)'
> first required here
> make[2]: *** [src/osgPlugins/exr/CMakeFiles/osgdb_exr.dir/ReaderWriterEXR.o]
> Error 1
> make[1]: *** [src/osgPlugins/exr/CMakeFiles/osgdb_exr.dir/all] Error 2
> make: *** [all] Error 2
>
> Because of this compile error I've just comment out the inclusion of the exr 
> plugin from src/CMakeLists.txt:
>
> IF(OPENEXR_FOUND)
> #    ADD_SUBDIRECTORY(exr)
> ENDIF(OPENEXR_FOUND)
>
> So at least it doesn't break the build for others.
>
> Must admit I'm pretty miffed with having to do lots of work trying complete a 
> half backed submissions - I have dozens of submissions to review and merge 
> and way too many have required me to dive in fix bugs, fix porting issues.
>
> Decent submissions work out of the box, and take five minutes of my time to 
> review, compile and check-in.  Submissions like these suck hours of my time.  
> Pile a dozen of such submissions up on one week I you completely suck up all 
> my time.  I have to earn a living too guys...  I can't just do open source 
> charity work all the time.
>
> So please can someone fix this stuff and get back to me when it actually 
> works.
>
> Robert.
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to