Robert,

All compile cleanly now, thanks.

Roger

Robert Osfield wrote:
Hi Roger,

I've just done a check and my attempt at a check-in of Wojteck's fixes
didn't succeed this morning, and I didn't spot the error.

I have just cleaned up the svn reported errors and have now done what
looks to be a successful check-in.  A build with float matrices has
also gone cleanly.

Could you do an update and let me know how you get on.
Robert.

On Mon, Oct 6, 2008 at 1:54 PM, Roger James <[EMAIL PROTECTED]> wrote:
  
Wojciech,

I have been using float matrices for entirely historical reasons. It is
probably time that I moved with the times and used doubles! By the way it
looks like Roberts merge has missed some of your changes as I still get
errors. I have posted on osg-submissions about this.

Roger

Wojciech Lewandowski wrote:

Thanks, Robert

Roger, I have modified the code so that it explicitly uses Matrixd in
problermatic cases. So in practice there are no compilation errors, but
shadows are still computed using doubles. I would not risk using float
Matrices internally because I saw how vulnerable was ConvexPolyhedron code
to lower precision. ConvexPolyhedron performs crucial role in shadow volume
computations.
I also noticed that CullVisitor uses double Matrices as well. So I have one
more good excuse because all classes based on ViewDependentShadowTechnique
are closely tied to CullVisitor ;-)

Cheers,
Wojtek


----- Original Message -----
From: Roger James
To: OpenSceneGraph Users
Sent: Monday, October 06, 2008 12:05 PM
Subject: Re: [osg-users] Compile errors in SVN head shadow codewith
floatmatrices
Robert Osfield wrote:

On Sat, Oct 4, 2008 at 9:40 PM, Wojciech Lewandowski
<[EMAIL PROTECTED]> wrote:


Thanks,

I will try to fix these. As soon as possible.


Wojtek's fixes are now checked in  ;-)
_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org



Thanks guys,

That was quick!

Roger

    


_______________________________________________
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Reply via email to