Hi JS et. al., I've now checked in a number of warning fixes, out of over 1000 warnings that should be removed (mainly repeats) I think just four were actual bugs fixes, whilst they might be minor bugs it's still nice to see them caught and hopefully fixed . The bulk left are unused parameter and assignment in conditionals.
I've reviewed almost all the assignment in conditional warnings and all look perfectly correct code, fixing the code to not use an assignment in an if() statement would lead to more code, so rather award scoping and more opportunities to introducing bugs. I really detest it when warnings appear on valid C/C++ code that has no ambiguity in it, this one boils down to prohibiting use of a particular feature of the language because some careless programmers might misuse it, but in the process screwing up things for programmers who actually know what they are doing. For these stopid warning cases I think the right thing to do is just disable them as they cause more harm than good. The warning number is C4706. The unused parameter warnings are for typically benign non usage of parameters that won't affect anything, but are easily fixable by /* commenting out */ the variable name or just deleting it. Sometime the variable name implies so extra information so is useful to keep in. My though now is to add suppression of C4706 into include/osg/Export and then review each of the existing suppressed warnings to see if we can remove ones that no longer effect us. The warning codes used date back to VS 6.0 days, and things have moved on a lot in compiler and on the OSG side to warrant a revist of which warnings get suppressed. Robert. _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
