Hi J-S, On Mon, Jan 5, 2009 at 7:40 PM, Jean-Sébastien Guay <[email protected]> wrote: > I can, but I would think you'd prefer to "offload" that tedious task to some > other developers (me in this case) since it can be pretty time consuming... > > I suggest you let me have a bash at fixing them (at least the most obvious > of them, which may well be 95% of them) and then I'll send you the others.
Off-loading warning fixes is a double edge sword again... some of the fixes might not be as trivial as they at first look so a quick fix can introduce bugs, the more you know about the code the less likely such a mistake will be made - which is why I undertook the warnings purge before Christmas, I'm familiar with the widest set of OSG code. Fixing bugs later on typically takes far more time than avoiding it in the first place, so taking on the task seemed like a more efficient thing to do. If you post the warnings I can have a quick look at them and make a judgement call on the potential risk of associated code changes, if it's low for a certain class of warning then having others dive in is a help. Sometimes I have to change warning fixes for coding style as well so we'll need to illustrate a warning, suggest a fix, then make sure this is good enough to merge and then roll this fix style out to all similar fixes, otherwise I'll end up having to reject fixes or manually fixing them myself anyway. Robert. _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
