On 5/10/2011 7:11 PM, Paul Martz wrote:
On 5/3/2011 3:02 PM, Ryan Pavlik wrote:
I'd like to propose my fixes that I sent in on -submissions pre-2.8.4: all
except the VC2010 build fix still apply. They are these two:
Improvements to osgconv:
https://github.com/rpavlik/osg/compare/OpenSceneGraph-2.8...improve-osgconv
(I've also forward-ported these to trunk:
https://github.com/rpavlik/osg/compare/master...improve-osgconv-trunk )
So, if I understand correctly, you did not post this change to osg-submissions
for inclusion in OSG's svn trunk, is that correct? Or, you did post them, but
they are awaiting action by Robert?
Has anyone other than you tested the changes?
What, exactly, are these improvements to osgconv? (No, I haven't looked at the
code -- yet.)
Having reviewed the code, I see two changes:
1) A simple change to an error message in osgconv.cpp. Looks straightforward.
2) A change to the image file name format as output by the dot OSG plugin. Not
sure I understand this one, but it doesn't appear to be an "improvement to
osgconv". Did you include this by mistake?
-Paul
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
