Hi Glenn, I don't think the BufferData will be serialized correctly prior to 3.5.6 so the second block in your revised code won't help, I would suggest just leaving your original TextureBuffer serializer implementation in place for versions prior to 3.5.6.
Cheers, Robert. On 27 March 2017 at 17:28, Glenn Waldron <[email protected]> wrote: > Robert, > > Only one :) And I will let them know the details. It's only used for > caching, so preserving existing files is not critical. > > In the meantime I preserved our "old" way of doing it for pre-3.5.4 version > (before getBufferData was available), and copied your updated method for > 3.5.5-3.5.6 versions. Hopefully that plugs the holes. > > https://github.com/gwaldron/osgearth/blob/master/src/osgEarth/TextureBufferSerializer.cpp > > > Glenn Waldron > > On Mon, Mar 27, 2017 at 11:13 AM, Robert Osfield <[email protected]> > wrote: >> >> Hi Glenn, >> >> I have just had a look at osgEarth's implementation of the >> TextureBuffer serializer and it's different from the core OSG one, the >> later is a more complete implementation. >> >> For backwards compatibility of older .osgb/.osgx/.osgt files generated >> by osgEarth applications that leverage the osgEarth's TexutreBuffer >> serializer we'd have a potential conflict. Perhaps one way to resolve >> this would be to version OSG's new TextureBuffer so that for older >> versions the osgEarth style implementation is used, while on recent >> versions the latest is used. >> >> How many files/osgEarth users do you think might be affected by this >> issue? >> >> Robert >> >> Robert. >> >> >> >> On 27 March 2017 at 15:16, Glenn Waldron <[email protected]> wrote: >> > Robert, >> > >> > Yes, it's in the latest stable release - version 2.8. >> > >> > I will add the versioning to our master branch as well as the 2.8 >> > branch. >> > >> > Thanks! >> > >> > >> > Glenn Waldron >> > >> > On Mon, Mar 27, 2017 at 9:47 AM, Robert Osfield >> > <[email protected]> >> > wrote: >> >> >> >> Hi Glenn, >> >> >> >> On 27 March 2017 at 14:22, Glenn Waldron <[email protected]> wrote: >> >> > Agreed, we did this out of temporary necessity; the right thing >> >> > moving >> >> > forward is for osgEarth to check the OSG version when >> >> > creating/registering >> >> > the osg::TextureBuffer serializer. >> >> >> >> Testing for an OSG version of 3.5.6 or later would probably be >> >> appropriate. >> >> >> >> Are the osgEarth TextureBuffer serilializer part of a stable release >> >> of osgEarth? >> >> >> >> Robert. >> >> _______________________________________________ >> >> osg-users mailing list >> >> [email protected] >> >> >> >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> > >> > >> > >> > _______________________________________________ >> > osg-users mailing list >> > [email protected] >> > >> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org >> > >> _______________________________________________ >> osg-users mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > _______________________________________________ > osg-users mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > _______________________________________________ osg-users mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
