Hm, I thought the idea of latesttemp was to never interefere with the
85C reading. A value of 1 would mean it denies 85C today?
enum temperature_problem_flag { allow_85C, deny_85C, } ;
Allow = 0, deny = 1..
And deny in latesttemp means returning error instead of gbGOOD.
On 06/12/16 12:17, Stefano Miccoli wrote:
> maybe we should simply patch
>
> *--- a/module/owlib/src/c/ow_1820.c*
> *+++ b/module/owlib/src/c/ow_1820.c*
> @@ -384,7 +384,7 @@static ZERO_OR_ERROR FS_10temp(struct
> one_wire_query *owq)
>
>
>
> static ZERO_OR_ERROR FS_10latesttemp(struct one_wire_query *owq)
> {
> - return GB_to_Z_OR_E(OW_10latesttemp(&OWQ_F(owq), 1, PN(owq)));
> + return GB_to_Z_OR_E(OW_10latesttemp(&OWQ_F(owq), allow_85C,
> PN(owq)));
> }
>
>
>
> static ZERO_OR_ERROR FS_10temp_link(struct one_wire_query *owq)
> @@ -412,7 +412,7 @@static ZERO_OR_ERROR FS_22temp(struct
> one_wire_query *owq)
>
>
>
> static ZERO_OR_ERROR FS_22latesttemp(struct one_wire_query *owq)
> {
> - return GB_to_Z_OR_E(OW_22latesttemp(&OWQ_F(owq), 1, PN(owq)));
> + return GB_to_Z_OR_E(OW_22latesttemp(&OWQ_F(owq), allow_85C,
> PN(owq)));
> }
>
>
>
> // use sibling function for fasttemp to keep cache value consistent
>
> S.
>
>> On 06 Dec 2016, at 12:09, Martin Patzak (GMX) <martin.pat...@gmx.de
>> <mailto:martin.pat...@gmx.de>> wrote:
>>
>>
>>>> Unfortunately without any other error flag! That's why I
>>>> implemented a way to accept a temperature of 85.0 only, if the previously
>>>> read temp was in that range (82-88), otherwise I just skip this reading and
>>>> try once again.
>>>>
>>> This is exactly what owfs does and what leads to this error.
>>>
>>> Currently I'm in favor of throwing all that 85°C "fixup" code out of
>>> owfs completely. If there's an error in your electrical setup, you have
>>> to fix it there, not by throwing more and more software workarounds at it.
>> *LIKE*
>>
>> ------------------------------------------------------------------------------
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today.http://sdm.link/xeonphi
>> _______________________________________________
>> Owfs-developers mailing list
>> Owfs-developers@lists.sourceforge.net
>> <mailto:Owfs-developers@lists.sourceforge.net>
>> https://lists.sourceforge.net/lists/listinfo/owfs-developers
>
>
>
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today.http://sdm.link/xeonphi
>
>
> _______________________________________________
> Owfs-developers mailing list
> Owfs-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/owfs-developers
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/xeonphi
_______________________________________________
Owfs-developers mailing list
Owfs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/owfs-developers
