https://bugzilla.redhat.com/show_bug.cgi?id=2443717



--- Comment #23 from Neal Gompa <[email protected]> ---
Some more spec review:

> %build
> %global _vpath_builddir %{gtk3dir}
> %cmake -DwxBUILD_TOOLKIT=gtk3 -DwxBUILD_TESTS=ALL 
> -DwxUSE_ARTPROVIDER_TANGO=OFF
> %cmake_build
> 
> %global _vpath_builddir %{qt6dir}
> %cmake -DwxBUILD_TOOLKIT=qt -DwxBUILD_TESTS=ALL
> %cmake_build

Unless we're still trying to have this in EPEL 9 and older, this should be
using the new %conf section, so it would look like so:

"""
%conf
%define _vpath_builddir %{gtk3dir}
%cmake -DwxBUILD_TOOLKIT=gtk3 -DwxBUILD_TESTS=ALL -DwxUSE_ARTPROVIDER_TANGO=OFF

%define _vpath_buildder %{qt6dir}
%cmake -DwxBUILD_TOOLKIT=qt -DwxBUILD_TESTS=ALL

%build
%define _vpath_builddir %{gtk3dir}
%cmake_build

%define _vpath_buildder %{qt6dir}
%cmake_build
"""

I'm also guessing that "xwfb-run" still doesn't work?

As far as replacing alternatives, I was going to suggest something like this
for wxGTK-devel:

"""
Provides: wxWidgets-toolkit-devel
Conflicts: wxWidgets-toolkit-devel
RemovePathPostfixes: .gtk3ucfg
"""

And this for wxQt-devel:

"""
Provides: wxWidgets-toolkit-devel
Conflicts: wxWidgets-toolkit-devel
RemovePathPostfixes: .qt6cfg
"""

And then the wx-config variants would be suffixed as "wx-config.gtk3ucfg" and
"wx-config.qt6cfg". The suffix would be stripped during rpmbuild time, and the
result are mutually conflicting packages where you have to pick one or the
other for the application being built.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2443717

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202443717%23c23

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to