https://bugzilla.redhat.com/show_bug.cgi?id=2443717
--- Comment #26 from Tarulia <[email protected]> --- (In reply to Neal Gompa from comment #25) > Admittedly, the conflict mainly comes from wx-config. I'm also kind of iffy > about having our default toolkit be GTK3 given that it's a dead-end toolkit, > but I'm also cognizant that wxQt is relatively new... I'd rather everyone be > forced to be explicit about this, but the developer thing is a good point. I'm with you on that one, mostly because I have a dislike for some of the design decisions in GTK3 (some of which are very annoying to deal with in Aegisub, hence my wxQt adventure). Regardless of that, 3.24 is still actively maintained, so it's not dead *yet*. More importantly though, currently all wxWidgets based packages are built with it, and arguably - regardless how stable (or not) wxQt is - a package review is probably not the right place to change the default. Moreover, wxWidgets themselves define GTK3 as the default[1]: ``` elseif(UNIX) set(wxDEFAULT_TOOLKIT gtk3) … wx_option(wxBUILD_TOOLKIT "Toolkit used by wxWidgets" ${wxDEFAULT_TOOLKIT} ``` So for better or worse - in the spirit of "upstream first" - I think it makes sense to keep it that way. There is also a GTK4 option, though I don't know how well supported this is. It was added 7 years ago[2], but Arch for their part disables the build. Speaking of options, wxWidgets also provides a way to build CLI-only applications and has a corresponding wx-config for it. It's built using -DwxUSE_GUI=OFF. Why one would do that I don't know, but it is an option. The question is whether this should also be built here? On another note, I just noticed the spec still references wx-config in Source10, but then doesn't use it. Probably makes sense to comment or remove that too. [1] https://github.com/wxWidgets/wxWidgets/blob/8d8967a29ac76b78a02b79eab7494545f09fff06/build/cmake/toolkit.cmake#L33-L41 [2] https://github.com/wxWidgets/wxWidgets/commit/46a94c2b48cc0aafe9fef1ff4d98d1f44770870c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2443717 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202443717%23c26 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
