https://bugzilla.redhat.com/show_bug.cgi?id=2480195

[email protected] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #20 from [email protected] ---
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0", "Apache License
     2.0 and/or GNU General Public License, Version 2", "Khronos License",
     "GNU General Public License, Version 2", "MIT License", "Apache
     License 2.0 and/or GNU General Public License v2.0 or later [obsolete
     FSF postal address (Temple Place)]", "*No copyright* MIT License",
     "BSD 3-Clause License", "*No copyright* Apache License 2.0". 11346
     files have unknown license. Detailed output of licensecheck in
     /sfs/fedora-review/xrt/review-xrt/licensecheck.txt

BSD 3-Clause License
--------------------
xrt-2.25.0-build/xrt-2.25.0/xrt/XRT/src/runtime_src/core/common/gsl/ThirdPartyNotices.txt


THIRD-PARTY SOFTWARE NOTICES AND INFORMATION
Do Not Translate or Localize

GSL: Guidelines Support Library incorporates third party material from the
projects listed below.

-------------------------------------------------------------------------------
Software: Google Test
Owner: Google Inc.
Source URL: github.com/google/googletest
License: BSD 3 - Clause
Text:
    Copyright 2008, Google Inc.
    All rights reserved.

    Redistribution and use in source and binary forms, with or without
    modification, are permitted provided that the following conditions are
    met:

        * Redistributions of source code must retain the above copyright
    notice, this list of conditions and the following disclaimer.
        * Redistributions in binary form must reproduce the above
    copyright notice, this list of conditions and the following disclaimer
    in the documentation and/or other materials provided with the
    distribution.
        * Neither the name of Google Inc. nor the names of its
    contributors may be used to endorse or promote products derived from
    this software without specific prior written permission.

    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
    "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
    LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
    A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
    OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
    LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
    DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
    THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
    (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-------------------------------------------------------------------------------

- There is no googletest source, this is a false positive.

Khronos License
---------------
xrt-2.25.0-build/xrt-2.25.0/xrt/XRT/NOTICE

The actual Khronos code was rm-ed for
rm -rf xrt/XRT/src/include
rm -rf xrt/XRT/src/runtime_src/xocl

this is good too..


ELF binaries found in upstream tarball:
  1. .../aie-rt/driver/tests/utest/elf_files/aieml_elfs/passthrough
  2. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/passthrough
  3. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/overlap_elf
  4. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/large_elf
  5. .../aie-rt/driver/tests/utest/elf_files/aie_elfs/mmul

these are removed.

[!]: Package does not include license text files separate from upstream.
license.patch

patches are removed, good here too.

Thanks for the update and changes
Approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2480195

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202480195%23c20

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to