On 03/02/2018 03:22 PM, Magnus Hagander wrote: > > > On Fri, Mar 2, 2018 at 3:17 PM, Alvaro Herrera <alvhe...@alvh.no-ip.org > <mailto:alvhe...@alvh.no-ip.org>> wrote: > > Magnus Hagander wrote: > > On Wed, Feb 28, 2018 at 10:07 PM, Tomas Vondra > <tomas.von...@2ndquadrant.com <mailto:tomas.von...@2ndquadrant.com> > > > > I'd argue this is merely a mistake in the --help text. Firstly, > > > relfilenodes are OIDs too, so I don't think "-o" is incorrect. > Secondly, > > > the SGML docs actually say: > > > Yeah, that one is my fault. It used to say oid all over but I noticed > and > > fixed it. Except I clearly missed the --help. > > Obviously option names are completely arbitrary -- you could say > "-P relfilenode" and it'd still be 'correct', since it works as > documented. But we try to make these options mnemotechnic when we can, > and I don't see any relation between "-o" and "relfilenode", so I > suggest picking some other letter. There's a whole alphabet out there. > > Either "-r" or "-f" works better for me than "-o". > > > I have no problem with changing it to -r. -f seems a bit wrong to me, as > it might read as a file. And in the future we might want to implement > the ability to take full filename (with path), in which case it would > make sense to use -f for that. >
+1 to -r -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
