On Tue, Jan 29, 2013 at 11:43 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Tue, Jan 29, 2013 at 3:12 AM, Alvaro Herrera > <alvhe...@2ndquadrant.com> wrote: >> Phil Sorber escribió: >>> On Mon, Jan 28, 2013 at 11:20 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >>> > Maybe. But I'm not inclined to add new libpq interface at this stage. >>> > Because we are in the last CommitFest and I'm not sure whether >>> > we have enough time to implement that. Instead, how about using >>> > both PQconninfoParse() and PQconndefaults() like uri-regress.c does? >>> > Or just remove that output message? At least I don't think that the >>> > information about host and port needs to be output. Which would make >>> > the code very simpler. >>> >>> I think that output is important as do others up thread. I think it'd >>> be simpler to just disable dbname's ability to double as conninfo. If >>> we are looking for easy, that is. >>> >>> I don't mind duplicating the behavior from conninfo_array_parse() or >>> uri-regress.c either. I can just put a comment that at some point in >>> the future we should add a libpq interface for it. >> >> I suggest duplicate the code for 9.3, and submit a patch to refactor >> into a new libpq function for CF2013-next. If the patch is simple >> enough, we can consider putting it into 9.3. > > Agreed. > > Regards, > > -- > Fujii Masao
OK, here is the patch that handles the connection string in dbname. I'll post the other patch under a different posting because I am sure it will get plenty of debate on it's own.
pg_isready_con_str.diff
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
