On Sun, Sep 13, 2015 at 12:43 PM, Ildus Kurbangaliev <i.kurbangal...@postgrespro.ru> wrote: > Added changes related to the latest master (for individual LWLocks > definitions)
If I haven't said this clearly enough already, I'm not OK with changing the tranche name from char * to a fixed-size character array. Nor am I OK with limiting the maximum number of tranches to 64. I worked hard to set this system up so that it did not have limits on the number of tranches or the lengths of their names, and I don't see any good reason to add those limitations now. I would like to avoid adding an argument to every call to SimpleLruInit(). It's already got two arguments that are basically names; let's avoid introducing a third one. Instead, let's decide on a naming convention that we ca use for both locks and shared memory segments. We haven't worried about that much in the past because this stuff was only exposed to developers, but that's changing now. So let's come up with something that will be nice for users and adopt a uniform convention. I don't think it should be NameOfSubsystemLocks as you have it here. That's too easy to confuse with heavyweight locks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
