Thanks everyone for the held and feedback on this patch! -- Paul Ramsey http://cleverelephant.ca http://postgis.net
On November 3, 2015 at 3:47:37 PM, Tom Lane (t...@sss.pgh.pa.us) wrote: Robert Haas <robertmh...@gmail.com> writes: > On Tue, Nov 3, 2015 at 2:57 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Paul Ramsey <pram...@cleverelephant.ca> writes: >>> [ 20151006b_postgres_fdw_extensions.patch ] >> There might be a case for raising a WARNING during >> postgres_fdw_validator(), but no more than that, IMO. Certainly ERROR >> during regular use of the server is right out. > Agreed. I don't know whether it's better to emit a WARNING or some > lower-level message (INFO, DEBUG), but I think an ERROR will suck due > to the pg_dump issues you mention. I've committed this with a WARNING during validation and no comment otherwise. I left out the proposed regression tests because they fail in "make installcheck" mode, unless you've previously built and installed cube and seg, which seems like an unacceptable requirement to me. I don't think that leaving the code untested is a good final answer, of course. The idea I was toying with was to create a dummy extension for testing purposes by means of doing a direct INSERT into pg_extension --- which is ugly and would only work for superusers, but the latter is true of "CREATE EXTENSION cube" too. Anybody have a better idea? regards, tom lane
