On Fri, Mar 25, 2016 at 9:09 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Mar 24, 2016 at 1:07 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: >> On 24/03/16 17:28, Robert Haas wrote: >>> On Wed, Mar 23, 2016 at 3:17 AM, Michael Paquier >>> <michael.paqu...@gmail.com> wrote: >>>> >>>> - 0001 fixes the global declarations of TIMEZONE_GLOBAL and >>>> TZNAME_GLOBAL to be WIN32-compliant. I got bitten by that in the ECPG >>>> compilation. >>> >>> So this isn't going to break other Windows builds? I mean, if we've >>> got the names for those symbols wrong, how is this working right now? >>> >> >> We didn't older versions just defined the other variants as well, but the >> _timezone and _tzname have been around since at least VS2003. > > I am unable to parse this sentence. Sorry.
Petr means that both _timezone and _tzname are objects defined in Visual Studio since more or less its 2003 release (https://msdn.microsoft.com/en-us/library/htb3tdkc%28v=vs.71%29.aspx). The oldest version on the buildfarm is Visual Studio 2005, and I agree with him that there is no need to worry about older versions than VS2003. The issue is that VS2015 does *not* define timezone and tzname (please note the prefix underscore missing in those variable names), causing compilation failures. That's why I am suggesting such a change in this patch: this will allow the code to compile on VS2015, and that's compatible with VS2003~. -- Michael -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers