Here's a v2 that does it like that.

Applies, compiles, overall & pgss make check are both ok.

Personnally I find having RawStmt only for the top parsed statement cleaner, and it significantly reduces changes in the parser, as expected, without inducing too much changes elsewhere.

Same comment as on v1: I'm wondering about the actual coverage of the default tests... I cannot say I understand everything.

It ends up being about 30 fewer lines of code overall, despite there being four places that have to make ad-hoc RawStmt nodes. On the whole I feel like this is cleaner,

I agree: Better typing, more homogeneous code (PlannedStmt for all), less ad-hoc checks to work around utility statements...


Sent via pgsql-hackers mailing list (
To make changes to your subscription:

Reply via email to