On 29.03.2017 20:14, Arthur Zakirov wrote:

I wanted to implement subscripting for ltree or hstore extensions.
Subscripting for ltree looks more interesting. Especially with slicing.
But I haven't done it yet. I hope that I will implement it tomorrow.


I've implemented fetching ltree elements using subscripting. But haven't implemented assigning ltree elements yet. I'll send second patch after implementing assigning.

Now you can execute the following query:

SELECT ('Top.Science.Astronomy.Astrophysics'::ltree)[1:2];


But I've noticed about some points.

In array_subscript_parse() passed uninitialized values of "typesource" and "typeneeded" variables for coerce_to_target_type().

+                       typesource = exprType(assignExpr);
+                       typesource = is_slice ? sbsref->refcontainertype : 

Here is the bug. Second variable should be "typeneeded". Moreover these assignments should be moved up to first coerce_to_target_type() execution.

+       foreach(l, sbsref->reflowerindexpr)
+       {
+               List *expr_ai = (List *) lfirst(l);
+               A_Indices *ai = (A_Indices *) lfirst(list_tail(expr_ai));
+               subexpr = (Node *) lfirst(list_head(expr_ai));

This code looks like a magic. This happens because of appending A_Indeces to lowerIndexpr:

-                       subexpr = NULL;
+                       lowerIndexpr = lappend(lowerIndexpr, 
list_make2(subexpr, ai));

And this A_Indeces used only when slicing is not used to make a constant 1. Maybe there are another way?

Also it would be better if "refevalfunc" and "refnestedfunc" had pointers to functions not Oid type. Now you need to create "..._fetch" and "..._assign" functions in catalog and in "..._parse" function you need get their Oid using to_regproc() function.

Can we use IndexAmRoutine structure method, when you use only pointers to necessary functions? You can see an example in blhandler() function in blutils.c.

The last point is about the tutorial. As Tom pointed it is not useful when the tutorial doesn't execute. It happens because there is not "custom" type in subscripting.sql. Also it contradicts the README of tutorials.

Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to