On 05.04.2017 16:06, Arthur Zakirov wrote:
On 04.04.2017 15:41, Dmitry Dolgov wrote:
Sorry for late reply. Here is a new version of the patch, I rebased it
fixed those issues you've mentioned (pretty nasty problems, thank you for

Thank you!

I've looked at the patch again.

Sorry maybe it's too naive. Also I was wondering.

+       element_type_id = transformArrayType(&array_type, &array_typ_mode);
+       sbsref->refelemtype = element_type_id;

I don't understand this part of the patch. Why is it necessary to execute transformArrayType() second time? It was executed in transformContainerSubscripts().

+       if (!OidIsValid(elementType))
+               elementType = containerType;

This part looks strange to me too.

It this parts are necessary it would be good to add comments.

Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to