It may work for some, but it's not correct. I was out at the swimming pool for example, so noticing us that you are going to commit something in ten minutes is not fair. BTW what is the reason that this patch is needed in fact?
All examples should have PHP tags, for example this makes the livedocs versions have pretty colors. And it's in the coding standards.
I know about this problem. All the examples had pretty colors in the extended CHM versions before livedocs came into existance. I have some code for it to detect if an example has no <? in it, and add a preceding and ending delimiter in this case. It worked. The problem with these commits is for translations, it made exta work which makes translators work a little bit harder.
I have also seen things like deleted newlines in Mehdi's commits in the name of "fixing structures". Also some "and" words moved from one line to another in see also lists. These are also things which are not structural fixes, but plain WS fixes, of which the only affect is to make translators' life harder. It would be nice to think of translators too, who work with revision numbers and diffs of the files.
Goba
-- PHP Documentation Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
