On Tue, Apr 11, 2017 at 6:20 PM, Marek Olšák <mar...@gmail.com> wrote: > On Tue, Apr 11, 2017 at 4:39 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >> On Tue, Apr 11, 2017 at 5:08 AM, Marek Olšák <mar...@gmail.com> wrote: >>> >>> >>> On Apr 10, 2017 11:11 PM, "Ilia Mirkin" <imir...@alum.mit.edu> wrote: >>> >>> Is this substantially different than patch-single-vert.shader_test or >>> patch-pair-verts.shader_test? Is the 4 vertices that's important to >>> your test? If so, patch-four-verts.shader_test seems like a better >>> name. >>> >>> >>> That's a really bad name, because it doesn't tell me that the test is >>> trivial. See, I didn't even bother checking what >>> patch-pair-verts.shader_test does. Bad name. >> >> So are sanity, nop, trivial, sanity2... All the tests are trivial >> except quads.shader_test as I recall. Perhaps rename them all with a >> "trivial-" prefix? Or make a dir? > > Well, at this point... if you don't want this patch, I'll just drop > it. It was useful when I needed it.
The main point of the test was that the vertex shader was completely empty. That was the property I needed. I think no other test has that. The same applies to the new trivial GS test. Marek _______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
