While the revised test prevents seeing the message for user images and for non-OpenSolaris platforms (which presumably would never be used for a full image), couldn't the need for the message be determined from the contents of the packages being updated? That way, when the package content no longer requires the message, the message will automatically go away.

The process could work as follows:
1) create the plan
2) from the list of packages to be updated, extract some attribute that indicates the type of change from all intervening versions. (this attribute would be among those intended to replace patch README contents)
3) if the list from step (2) requires the message, then print the message.

This could also be used to determine whether a reboot is needed after an image-update.

Tom

Dan Price wrote:
On Fri 25 Jul 2008 at 08:19PM, [EMAIL PROTECTED] wrote:
I have no problems with what you're showing there.
I think this is the webpage you're looking for:
http://opensolaris.org/os/project/indiana/resources/rn3/

That URL says nothing about image-update.
Actually, the second section does talk about the GRUB issue but it
doesn't explicitly mention "image-update".  We'll work on updating it
to do so.

So I've revised the test which emits this as follows:

        if not noexecute and img.is_liveroot():

So, we'll only emit this as we begin to update images which are
currently "live roots".  It's not perfect, but should cover about 99%.

I changed the message to incorporate the suggestions given:

  ---------------------------------------------------------------------------
  WARNING: image-update of a system should be performed only after reviewing
upgrade notes posted at: http://opensolaris.org/os/project/indiana/resources/rn3/
  ---------------------------------------------------------------------------
Have you reviewed the upgrade notes? [y,n,q] y


Thoughts?

        -dp


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to