Michal Pryc wrote: > Brock, > I will move those bits to _extract_file() do you think we should have > also an function argument there instead of __init__ ? I was following > the way it was done in other modules. > > My feeling is that if it requires lots of plumbing to get the cancelation to _extract_file, or if PkgPlan's will be using it in other locations, put it in __init__. If this is the only method in PkgPlan that will be using it, and it doesn't require lots of changes, it should be an argument to _extract_file.
Brock > best > Michal > > Brock Pytlik wrote: > >> Only comment I have is I think I'd be happier if check_cancellation was >> an argument to pkgPlan.download, rather than being part of the >> constructor, as long as this doesn't require significant replumbing. >> >> I'd also like K, or someone else familiar with the transport code to >> take a look before it goes into the gate. >> >> Brock >> >> Michal Pryc wrote: >> >>> Hi, >>> >>> Bug: >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3717 >>> >>> >>> Webrev: >>> http://cr.opensolaris.org/~migi/08_10_2008_cancel_during_download_3717/ >>> >>> I would really be happy if you could review this ASAP. >>> >>> I have tested those bits and the cancelation works fine. If cancel was >>> requested the cancel exception is thrown after the file being >>> downloaded will finish. >>> >>> best >>> Michal >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
