This is great Michal, we can now cancel cleanly before each file download duringhte prepare phase and your patch is consistent with the use of the self.check_cancelation flag being used to support cancelation introduced by the new API in evaluation [http://cr.opensolaris.org/~bpytlik/ips-api-v7/src/modules/client/imageplan.py.wdiff.html]
+1 JR P.s. Look forward to seeing file cancel support during a download of larger multi meg files, but that's not for 2008.11 :) Michal Pryc wrote: > Hi, > > Bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=3717 > > > Webrev: > http://cr.opensolaris.org/~migi/08_10_2008_cancel_during_download_3717/ > > I would really be happy if you could review this ASAP. > > I have tested those bits and the cancelation works fine. If cancel was > requested the cancel exception is thrown after the file being > downloaded will finish. > > best > Michal _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
