Shawn Walker wrote:
> Brock Pytlik wrote:
>> Webrev:
>> http://cr.opensolaris.org/~bpytlik/ips-1469-v1/
>>
>> Bug:
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1469
>> image-update by unprivileged user should give better error message
>
> client.py:
> line 1421: What if err.exc isn't a valid attribute because this is a
> different exception? Won't that cause an attributeerror?
>
The first thing that's checked is whether it's a CatalogRetrievalError,
those are guranteed to have an .exc attribute. If it's another kind of
exception, the first check will fail and the second will never be checked.
> line 1415-1420: In one error, you put leading whitespace as the
> first argument to emsg, in the other you include it in the translated
> string.
>
Good point, I'll pull the whitespace out in both.
> line 1417: s/permissions/privileges/ ?
>
Sure
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
