Brock Pytlik wrote: > Danek Duvall wrote: > > [snip] >> Of course, with this change, is "data" needed any more? Now "data" can >> simply be consed up in __str__(). >> >> > That's true, but only if the additional optional parameters are made > mandatory (and nothing relies on touching .data directly. In the > interest of making all changes as low risk as possible, I chose to only > add info to the exception, instead of reorganizing it. If it's ok, I'd > like to put the cleanup of this off to post-2008.11. > This is what I get from responding from memory. Actually, only the CatalogRetrivalError which happen because of a generic behavior are currently making use of these new options. The ones that are thrown from URL or HTTP errors don't use these options, and indeed would need a different set entirely. Since all the transport code is going to be blown up post-Nov, I think it makes sense to use this small change rather than refactoring the exception handling code and making the change into a bigger one.
New webrev at: http://cr.opensolaris.org/~bpytlik/ips-1469-v2/ Brock > [snip] >> >> > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
