On Fri, Oct 31, 2008 at 07:03:38PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-1469-v1/
This fix is premised on a catalog refresh being required before install or
image-update. But what if the user passes in --no-refresh? Won't we still
need a check at download time?
retrieve.py:
- line 124: I think this line should look like line 148. Right now, you
have four elements to the tuple which only needs three, and you're
passing in "prefix" in the position where "exc" is expected.
Of course, with this change, is "data" needed any more? Now "data" can
simply be consed up in __str__().
client.py:
- line 1414: If this ends up being None, the resulting message seems a
bit stilted to me -- it tells you what to do, but not what went wrong.
I'm not sure if we actually get into that situation, though, so perhaps
it's not worth fixing?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
