On Tue, Nov 04, 2008 at 04:55:15PM -0800, Brock Pytlik wrote:

> http://cr.opensolaris.org/~bpytlik/ips-1469-v3/

api_errors.py:

  - no need for spaces before the newlines in the error message.

image.py:

  - line 1123: I think you can consolidate the two tests into a single
    line:

        if errno == errno and e.filename:
            raise api error

    Is an instance of EnvironmentError guaranteed to have a filename
    member (or at least on rmdir)?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to