Danek Duvall wrote: > On Fri, Oct 31, 2008 at 07:03:38PM -0700, Brock Pytlik wrote: > > >> http://cr.opensolaris.org/~bpytlik/ips-1469-v1/ >> > > This fix is premised on a catalog refresh being required before install or > image-update. But what if the user passes in --no-refresh? Won't we still > need a check at download time? > I'm pretty sure that 43841 addressed the download time issue. > retrieve.py: > > - line 124: I think this line should look like line 148. Right now, you > have four elements to the tuple which only needs three, and you're > passing in "prefix" in the position where "exc" is expected. > Bah, you're right. > Of course, with this change, is "data" needed any more? Now "data" can > simply be consed up in __str__(). > That's true, but only if the additional optional parameters are made mandatory (and nothing relies on touching .data directly. In the interest of making all changes as low risk as possible, I chose to only add info to the exception, instead of reorganizing it. If it's ok, I'd like to put the cleanup of this off to post-2008.11. > client.py: > > - line 1414: If this ends up being None, the resulting message seems a > bit stilted to me -- it tells you what to do, but not what went wrong. > I'm not sure if we actually get into that situation, though, so perhaps > it's not worth fixing? > Hmm... ok, what if I add an else clause and produce a generic error? I don't think we can get in this situation right now, but never say never for the future.
I'll integrate these changes and post a new webrev. Brock > Danek > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
