On Mon, Nov 03, 2008 at 03:21:01PM -0800, Brock Pytlik wrote:
> I'm pretty sure that 43841 addressed the download time issue.
4381? Yes.
I'll note, though, with my fix for bug 4412 on Sunday, you may now end up
with a different stack trace:
Refreshing Catalog 4/4 srssTraceback (most recent call last):
File "./client.py", line 2139, in ?
__ret = main_func()
File "./client.py", line 2088, in main_func
return install(mydir, pargs)
File "./client.py", line 702, in install
update_index=update_index)
File ".../pkg/client/api.py", line 131, in plan_install
self.img.retrieve_catalogs(
File ".../pkg/client/image.py", line 1389, in retrieve_catalogs
self.update_installed_pkgs()
File ".../pkg/client/image.py", line 1114, in update_installed_pkgs
os.rmdir("%s/state/installed" % self.imgdir)
OSError: [Errno 13] Permission denied: '/var/pkg/state/installed'
which I think will bypass your exception handling, because it's not wrapped
in a CatalogException. I could be reading it wrong, though, so please
check to make sure. Quite obviously, my brain is running a little slow
today.
>> Of course, with this change, is "data" needed any more? Now "data"
>> can simply be consed up in __str__().
>
> That's true, but only if the additional optional parameters are made
> mandatory (and nothing relies on touching .data directly. In the interest
> of making all changes as low risk as possible, I chose to only add info to
> the exception, instead of reorganizing it. If it's ok, I'd like to put the
> cleanup of this off to post-2008.11.
Okay.
>> client.py:
>>
>> - line 1414: If this ends up being None, the resulting message seems a
>> bit stilted to me -- it tells you what to do, but not what went wrong.
>> I'm not sure if we actually get into that situation, though, so
>> perhaps it's not worth fixing?
>
> Hmm... ok, what if I add an else clause and produce a generic error? I
> don't think we can get in this situation right now, but never say never
> for the future.
Your proposal here doesn't sound substantially different than what you
already have. You can give it a shot, but we're probably okay as it is.
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
