Danek Duvall wrote:
On Mon, Feb 23, 2009 at 02:41:34PM -0600, Shawn Walker wrote:
Brock Pytlik wrote:
Shawn Walker wrote:
lines 301-302: don't use ' characters to quote key names, always use "
you included the % {} within the _(); it needs to be outside that
there should always be a space after : characters in dicts
Thanks for catching this, I meant for the dict to be outside. Just
curious, is ' vs " style or does it have different semantics?
Style; ask Danek. As far as I know, unlike perl, it doesn't have any
real effect except forcing to escape quotation marks.
Yeah, it's just style. We're using double-quotes generally. Probably
because it looks more natural to a C programmer. There are a few cases
where we use single-quotes because of heavy use of double-quotes inside the
string, and using the escape every time seems silly, though triple quotes
might work there, too. And, of course, there are a few places where the
single quotes are used for no good reason.
Also, I note at the end client/api_error.py, you have (well, Brock has):
"""
A long piece of text.
"""
which puts newlines before and after "A long piece of text.", which
probably not what you want. Either put backslashes after the open quotes
and at the end of the last line of text, or get rid of those newlines in
the code. (Unless, of course, you want the two blank lines there.)
Danek
Thanks for pointing that out Danek. I looked at all the error messages
and they looked fine to me but I think I probably like more white space
than most people so it looked right to me. To be consistent with the
other things we do, I'll make sure the extra newlines aren't there.
Unless there are other issues, I'll look to put this back this afternoon.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
