On 02/26/09 18:04, Brock Pytlik wrote:
Padraig O'Briain wrote:
I know that this has been committed but I have a question about the
command line.
I need to do pkg image-update be-name=bename to get it to work.
If I omit the = after --bename I get an error. However, if one looks
at the man page it does not look like the = is required.
Yep, I got the man page and usage message wrong.
Brock
Should I log a bug?
Padraig
Padraig
On 02/21/09 01:53, Brock Pytlik wrote:
Ok, hopefully last round of webrevs for this:
http://cr.opensolaris.org/~bpytlik/ips-3718-v3/
Brock
Shawn Walker wrote:
Brock Pytlik wrote:
New webrev at:
http://cr.opensolaris.org/~bpytlik/ips-3718-v2/
Shawn, I took several looks at those lines whose formatting you
thought were strange, and I didn't see anything wrong with them.
Would you take a look at this webrev and see if the concerns are
still there, and if so, what's wrong?
Other changes include adding check_be_name as a static method of
the API class and adding more text to the man page.
man/pkg.1.txt:
lines 26-27, 106: can you alphabetise the options?
yep
lines 108-118: i think it would be far more readable to separate
the "with -flag" text by newlines as we did for image-create.
yep
client.py:
lines 477-478: can you alphabetise the options?
yep
client/api_errors.py:
lines 277-278: suggest rewording as "Unable to clone the current
boot environment."
fixed
lines 287-292: suggest reformatting, rewording as:
return _("Unable to rename the boot environment currently named "
"%(orig)s to %(dest)s.") % { "orig": self.original_name,
"dest": self.destination_name }
This actually has different semantics than what's there now, but
I'll take another shot. (I used the """ mechanism b/c I think that
when the output crosses multiple lines, it's easier to account for
the 80 column output limit and see what the user would actually see
that way.
...I think that's the "right" way. Danek would know.
Yep brought Danek in and I think we came to a solution.
lines 301-302: don't use ' characters to quote key names, always
use "
you included the % {} within the _(); it needs to be outside
that
there should always be a space after : characters in dicts
Thanks for catching this, I meant for the dict to be outside. Just
curious, is ' vs " style or does it have different semantics?
Brock
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
