John Sonnenschein wrote:
So I'm not terribly sure that 8004 ought to be delivered with the same
changeset, but I'll pick the bug up.
For the time being though here's some new changes:
http://cr.opensolaris.org/~error404/7360/
So, don't bother changing server/catalog.py; it's mostly dead code (as
of changeset 1431) and nothing tests it. Please revert all changes to it.
src/depot.py:
line 193: options are listed in asciibetical order, so put this
before writable root; same with line 231, 267
line 196: missing '.'
line 473: extra newline
lines 474-479: please keep long option parsing in asciibetical order,
move this above --writable-root.
line 643: please keep the parameters in asciibetical order; they're
keyword arguments so position doesn't matter (all callers should be
using keywords and not relying on position)
modules/server/repository.py:
Is it anticipated that search will have other "knobs and switches" in
the future? If so, I'd prefer to separate out search configuration
somehow. I really don't want the repository to have to know about
working file sizes. If there aren't additional ones anticipated, I'll
live with this.
line 189: can you move this to line 187? Also, should this really be
a public property? I think '__' would be better.
line 726: (other places too) Instead of this construct
sort_file_max_size, I'd prefer to see this collapsed to a single
condition and to have __init__ default sort_file_max_size to
indexer.SORT_FILE_MAX_SIZE if not provided instead.
tests/cli/t_pkgdepotd.py:
Don't know if you can do this, but how do we actually verify that
this parameter has the desired effect?
lines 318, 335: please add brief docstrings to each test function.
Also, our naming convention is test_<name> (all lowercase) for the
actual tests. Please don't use camelCase for the test names.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
