Bart Smaalders wrote:

> http://cr.opensolaris.org/~barts/13242/

Is there another bug that you're fixing, about catalog updates in the
middle of publication?  It seems like there are some changes not related to
either of these two bugs.

importer.py:

  - line 61: comment character should line up.

  - line 1152: no need for the backslash

  - line 1456ff: you need spaces inside the message between the lines (ie,
    after "constrains", "Proper", "the", and "will").

  - line 1463: I can't see where any versions go into the FMRI.  And if
    there are no versions, then type=incorporate is a bit silly.  Do you
    need no-version=true magic here?

  - line 1467: in addition, you might check that there's a version on each
    FMRI, but that's just to make sure folks who don't know what they're
    doing don't screw things up.

  - lines 1505, 1470, 1424: trailing whitespace

Should we be getting rid of build_entire_incorporation?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to