Bart Smaalders wrote:
> http://cr.opensolaris.org/~barts/12817/
pkg_solver.py:
- line 292: you're pulling out tabs everywhere else; might as well not
add new ones here
- line 717: You're immediately overwriting "f" in some cases. Is this
intentional and overly clever, a bug, or just not useful? At the very
least, if not self.__dep_dict, then on line 724, f on the RHS is
whatever happened to come out of the loop on line 720.
- line 942: this could be done with setdefault().
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
