On 02/ 3/10 08:58 PM, Bart Smaalders wrote:
Fixes

13241 pkg install triggers system incorporation update

See discussion in bug report for details...

http://cr.opensolaris.org/~barts/13241/

So as I mentioned in the bug, the catalog should probably be changed to include the new set name=pkg.install-hold actions in the catalog.dependency part. Loading and parsing the catalog.summary part during install will use about 30% more memory (at least 30 megabytes) and it will be somewhat slower (how much, I don't know).

It's a fairly trivial change to make (about 10 lines), so I've posted a patch against your changeset here:

http://cr.opensolaris.org/~swalker/inst_hold_cat.patch

This change should not cause any issues with older catalog v1 clients as they simply take the catalog files and use them as-is.

It should be noted that the patch above changes the action filtering logic for the catalog, which means that the publication server will have to be updated (servers in read-only wouldn't matter). Publication clients don't have to be updated unless using file:// publication. You'd also need to start pkg.depotd with --rebuild after applying this patch for your own private workspace so that the catalog would be rebuilt with the action data in the correct part.

Finally, I do wonder about install-hold and renamed incorporations. If an incorporation with install-hold is renamed, should it still have the install-hold attribute in its terminal version?

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to