On Thu, Jan 14, 2010 at 05:37:19PM -0600, Shawn Walker wrote:
> full webrev (complete set of changes):
> http://cr.opensolaris.org/~swalker/pkg-lock-4-full/
>
> This set of changes (I believe) resolves all of johansen's comments.
Thanks, this looks a lot better. I think you've addressed all of my
previous concerns. I just have a few nits remaining.
image.py:
- lines 372-374: Sorry I didn't think of this sooner, but would you
add the date/time the lock was acquired to what's already in the
lockfile. This could be useful for debugging cases where a lock is
being held for much longer than it should have been.
- line 390: Can we use break here instead?
- lines 365, 389-392, 398: It seems like we might be able to avoid
having to perform the deleted file dance if the caller truncated the
file instead of removing it during unlock. Does the rm accomplish
something else that I've failed to account for?
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
