On 01/15/10 05:37 PM, Shawn Walker wrote:
On 01/15/10 05:18 PM, Edward Pilatowicz wrote:
src/modules/client/api_errors.py

- i'm not a python expert, so perhaps this is ok, but all the __init__
parameters to ImageLockedError default to None, and when returning
an error string you only check if pid and pid_name are None.
shouldn't you also check if hostname is None?

I could, it doesn't really hurt though.

To be clear, I've changed this.

Thanks,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to