On 02/04/10 11:51, Danek Duvall wrote:
Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/13241/
You're fixing bug 13968 here, too.
Thanks; I didn't realize a bug had been filed.
Does it make sense for a "normal" package (one without any incorporate
dependencies) to set this attribute?
Nope, and we don't pay any attention if they do.
pkg_solver.py:
- line 712,965,982: remove trailing spaces
- line 981: is there any reason to think we might have more than one
value for this attribute?
We may not - but this way other complex sets of inter-related software
can establish nested incorporations w/o interfering w/ the OS.
- line 994: This allows for "core-os" to release a hold by
"core-ostracized". Do you want to restrict it to the dotted hierarchy?
[r for r in relaxed_holds if hold == r or hold.startswith(r + ".")]
I'll do this - less chance for accidents.
- line 996: does this imply that we want an audit check at some point
that warns when you've set install-hold on a package that also has a
versioned dependency on another package? I'm also not sure how the
code following this has anything to do with non-incorporation packages.
I've updated the comments to address this.
Is it worthwhile testing that installing a package constrained by an
incorporation (and having a versioned dependency on that incorporation) as
well as the incorporation itself on the commandline works?
Done...
Webrev is updated w/ changes for all the reviews.
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
