src/util/publish/Makefile:
Line 57:
Can the "-r on-nightly" be changed to use a parameter for "on-nightly",
such as "CTEAMPUB"? I'm also looking forward as we get more than just
ON's zipped repository deliveries. Though I'm sure you are aware that
there are quite a few ON-specific parameters that will need to change at
some point. I am okay with how it is for now, though.
I'm also one who likes a comment line or two to explain what a routine
or script does. set-publisher could use a little more commenting,
especially with regard to the arguments.
-- Alan
On 03/24/10 07:28 AM, Liane Praza wrote:
On 03/24/10 07:14 AM, Rich Burridge wrote:
On 03/24/10 01:06, Liane Praza wrote:
Probably should file another bug to cover the publisher part of the
work for this push too, but please take a look at my proposed importer
changes to allow RE to start using ON (and soon other) consolidation
repositories in 136.
http://cr.opensolaris.org/~lianep/pkg-re/
This paves the way for the rest of the 136 sync, I believe. There's
also likely some more work to be done here, but this does allow
generation of a combined repository.
It's really a very small nit, but I suggest putting the "-C osnet"
part of
line 84 in src/util/distro-import/Makefile on its own line (and the same
for other consolidations as they get added in), so it's easier to
quickly
see what IPS consolidations are in a particular build.
Also consider...
If lines 85-87:
85 + -R \
86 +
$(ON_REPO)@consolidation/osnet/[email protected].$(BUILDID) \
87 + -E consolidation/osnet/[email protected].$(BUILDID)
are also all specific to a consolidation (i.e. every time a new
consolidation is added
there will be four similar lines -- including the -C one), maybe they
should be moved
out separately andIPS_CONSOLIDATION_OPTIONS_NNN just picks those up.
Something like:
OSNET_CONSOLIDATION = \
-C osnet \
-R \
$(ON_REPO)@consolidation/osnet/[email protected].$(BUILDID) \
-E consolidation/osnet/[email protected].$(BUILDID)
IPS_CONSOLIDATION_OPTIONS_136 = \
$(OSNET_CONSOLIDATION)
and then at a later build, something like:
IPS_CONSOLIDATION_OPTIONS_137 = \
$(OSNET_CONSOLIDATION) \
$(X_CONSOLIDATION)
and so on.
Both very good points, thanks. They're incorporated and webrev is
respun in place.
liane
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
