I refreshed the webrev page and it looks much better, thanks! I'll start
playing with the new version now.
-- Alan
On 03/24/10 08:50 AM, Liane Praza wrote:
On 03/24/10 08:20 AM, Alan Steinberg wrote:
src/util/publish/Makefile:
Line 57:
Can the "-r on-nightly" be changed to use a parameter for "on-nightly",
such as "CTEAMPUB"? I'm also looking forward as we get more than just
ON's zipped repository deliveries. Though I'm sure you are aware that
there are quite a few ON-specific parameters that will need to change at
some point. I am okay with how it is for now, though.
Did you look at the new set-publisher.sh and its friend
set-publisher.transforms? I'm using pkgmogrify now, rather than gsed,
and the idea is that new consolidations will add new transforms to
this file. I removed -r from set-publisher.sh based on that (private
mail) codereview suggestion from Dan.
Thanks for pointing out that I missed the -r in the Makefile. Fixed now.
Hopefully, everything's now generic enough to easily add new
consolidations... up next for me (after the signing we've been
discussing) is to write the instructions for us and other
consolidations to be able to experiment by changing
set-publisher.transforms and distro-import/Makefile.
I'm also one who likes a comment line or two to explain what a routine
or script does. set-publisher could use a little more commenting,
especially with regard to the arguments.
Done. Let me know if it's not sufficiently helpful.
Thanks for the review comments, Alan. Webrev is respun in place:
http://cr.opensolaris.org/~lianep/pkg-re/
liane
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
