On 09/21/10 15:11, Danek Duvall wrote:
Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/16327/
I hate to bikeshed (really!), but can we drop the "require-" from the type
names? I don't think it adds anything, and just makes the manifests more
cumbersome and harder to talk about. Perhaps "any" could be "anyof" or
"any-of".
any-of seems weak... I'll leave that as require-any, the others
we can make "origin" and "conditional"
depend.py:
- line 288: what happens if building the fmri fails?
This cannot happen here as the package is already installed.
In general, we don't deal elegantly with malformed fmris; this should
get some attention if we can do this in a efficient manner.
- line 995: is there no way that conditional dependencies could end up
here?
hmmm. We can print the dependency, but it's hard to express the
conditional nature... I'll mull this over.
Other comments incorporated...
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
