On Mon, 2010-09-20 at 19:35 -0700, Bart Smaalders wrote:
> On 09/20/10 19:22, Edward Pilatowicz wrote:
> > one last thing that came to mind (and perhaps this is just because of my
> > lack of knowledge about pkg) is that if we're not parsing attributes
> > when loading actions, then when do we do validation? during package
> > publication or perhaps pkglint?
> >
> > ed
>
> This is typically done during the creation...
as well as publication. pkg.action.Action.validate(..) gets called by
pkg.publish.transaction.add(..)
I tend to look on validation being tiered across several levels: on the
action itself when we really really need it there, on publication if it
makes sense, falling back to pkglint if the validation is either too
expensive to do elsewhere, or where the errors are specific to certain
attributes or are mostly harmless in terms of their ability to cause
damage.
The only pkglint check we have for dependencies so far, is to ensure we
don't have a 'require' dependency on a package marked as obsolete. I
should probably expand that set as a result of this putback.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
