On 2023/07/25 21:34, Thomas Frohwein wrote:
> On Tue, Jul 25, 2023 at 03:34:33PM -0300, Lucas de Sena wrote:
> > On 2023-07-25, Stuart Henderson wrote:
> > > On 2023/07/25 12:06, Lucas de Sena wrote:
> > > > On 2023-07-24, Thomas Frohwein wrote:
> > > > > 1. There are dependencies/WANTLIBS missing:
> > > >
> > > > Fixed.
> > >
> > > Missing lib: mad.2 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > > Missing lib: portmidi.0 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > > Missing lib: vorbis.9 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > > Missing lib: vorbisfile.6 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > > Missing lib: zip.4 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > >
> > > you need to add LIB_DEPENDS for the "NOT REACHABLE" ones, and re-run
> > > the check to pick up the additional WANTLIB.
> > >
> > > > > 3. What is the value of disabling fluidsynth in the Makefile? We have
> > > > > it in ports...
> > > >
> > > > It needs fluidsynth 2.0, we have 1.1.9 packaged.
> > >
> > > please add a comment explaining that.
> > >
> > > you have this,
> > >
> > > CONFIGURE_ENV = CFLAGS="-I${X11BASE}/include
> > > -I${LOCALBASE}/include"
> > >
> > > which overrides the default CFLAGS. Instead use
> > >
> > > CFLAGS += -I${X11BASE}/include -I${LOCALBASE}/include
> > >
> > > also remove the two -DCMAKE_BUILD_TYPE lines, they are handled
> > > by ports infrastructure.
> > >
> >
> >
> > Thanks for the explanation :)
> >
> > Is it ok?
>
> This looks good to me now and builds. I'm not sure about the value of
> DEBUG_PACKAGES in a port like this... It's 1.2M of space and unless you
> are actively working on refining the port by studying backtraces, I
> doubt that DEBUG_PACKAGES will be useful...
The point of DEBUG_PACKAGES is so that you already have a chance of
installing debug symbols to match the package if you run into a crash,
1.2M is nothing when we have things like this
-rw-r--r-- 1 root wheel 1.1G Jul 24 13:41 texlive_texmf-full-2022.tgz
-rw-r--r-- 1 root wheel 1.1G Jul 24 13:42 xonotic-data-0.8.6.tgz
-rw-r--r-- 1 root wheel 1.2G Jul 24 13:42 ufoai-data-2.5p1.tgz
-rw-r--r-- 1 root wheel 1.3G Jul 24 13:41 texlive_texmf-docs-2022.tgz
-rw-r--r-- 1 root wheel 1.4G Jul 24 13:42 urbanterror-data-4.3.4.tgz
-rw-r--r-- 1 root wheel 1.6G Jul 24 13:34 0ad-data-0.0.26.tgz
-rw-r--r-- 1 root wheel 1.8G Jul 24 13:36 flightgear-data-2020.3.17.tgz
> I like the more visually uniform use of tabs and the comment about
> fluidsynth v2.0 will be useful to know when we might be able to remove
> that CONFIGURE_ARG in the future...
>
> with or without DEBUG_PACKAGES, ok thfr@
couple of nits: make the comment a little more clear; put
MODCMAKE_LDFLAGS with CFLAGS (conceptually similar); actually
remove the second -DCMAKE_BUILD_TYPE
with that it's ok sthen@
--- Makefile.orig Tue Jul 25 18:53:17 2023
+++ Makefile Wed Jul 26 09:02:05 2023
@@ -25,17 +25,16 @@ LIB_DEPENDS = archivers/libzip \
devel/sdl2-mixer \
devel/sdl2-image
-# disable fluidsynth v2.0, which is not packaged
+# requires fluidsynth v2.0, currently we have 1.x
CONFIGURE_ARGS = -DWITH_FLUIDSYNTH=OFF
+MODCMAKE_LDFLAGS = -L${X11BASE}/lib -L${LOCALBASE}/lib
CFLAGS += -I${X11BASE}/include -I${LOCALBASE}/include
-DEBUG_CONFIGURE_ARGS = -DCMAKE_BUILD_TYPE=Debug
DEBUG_PACKAGES = ${BUILD_PACKAGES}
NO_TEST = Yes
-MODCMAKE_LDFLAGS = -L${X11BASE}/lib -L${LOCALBASE}/lib
WRKSRC = ${WRKDIST}/prboom2
post-install:
