On Tue, Jul 25, 2023 at 03:34:33PM -0300, Lucas de Sena wrote:
> On 2023-07-25, Stuart Henderson wrote:
> > On 2023/07/25 12:06, Lucas de Sena wrote:
> > > On 2023-07-24, Thomas Frohwein wrote:
> > > > 1. There are dependencies/WANTLIBS missing:
> > >
> > > Fixed.
> >
> > Missing lib: mad.2 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > Missing lib: portmidi.0 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > Missing lib: vorbis.9 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > Missing lib: vorbisfile.6 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> > Missing lib: zip.4 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
> >
> > you need to add LIB_DEPENDS for the "NOT REACHABLE" ones, and re-run
> > the check to pick up the additional WANTLIB.
> >
> > > > 3. What is the value of disabling fluidsynth in the Makefile? We have
> > > > it in ports...
> > >
> > > It needs fluidsynth 2.0, we have 1.1.9 packaged.
> >
> > please add a comment explaining that.
> >
> > you have this,
> >
> > CONFIGURE_ENV = CFLAGS="-I${X11BASE}/include
> > -I${LOCALBASE}/include"
> >
> > which overrides the default CFLAGS. Instead use
> >
> > CFLAGS += -I${X11BASE}/include -I${LOCALBASE}/include
> >
> > also remove the two -DCMAKE_BUILD_TYPE lines, they are handled
> > by ports infrastructure.
> >
>
>
> Thanks for the explanation :)
>
> Is it ok?
This looks good to me now and builds. I'm not sure about the value of
DEBUG_PACKAGES in a port like this... It's 1.2M of space and unless you
are actively working on refining the port by studying backtraces, I
doubt that DEBUG_PACKAGES will be useful...
I like the more visually uniform use of tabs and the comment about
fluidsynth v2.0 will be useful to know when we might be able to remove
that CONFIGURE_ARG in the future...
with or without DEBUG_PACKAGES, ok thfr@
> Cheers,
> Lucas de Sena
