On Wed, Jul 26, 2023 at 09:03:42AM +0100, Stuart Henderson wrote:
[...]
> > fluidsynth v2.0 will be useful to know when we might be able to remove
> > that CONFIGURE_ARG in the future...
> >
> > with or without DEBUG_PACKAGES, ok thfr@
>
> couple of nits: make the comment a little more clear; put
> MODCMAKE_LDFLAGS with CFLAGS (conceptually similar); actually
> remove the second -DCMAKE_BUILD_TYPE
>
> with that it's ok sthen@
One more issue: Lucas, it would be best if you are the maintainer of
the port to be involved in keeping it updated and working.
>
> --- Makefile.orig Tue Jul 25 18:53:17 2023
> +++ Makefile Wed Jul 26 09:02:05 2023
> @@ -25,17 +25,16 @@ LIB_DEPENDS = archivers/libzip \
> devel/sdl2-mixer \
> devel/sdl2-image
>
> -# disable fluidsynth v2.0, which is not packaged
> +# requires fluidsynth v2.0, currently we have 1.x
> CONFIGURE_ARGS = -DWITH_FLUIDSYNTH=OFF
>
> +MODCMAKE_LDFLAGS = -L${X11BASE}/lib -L${LOCALBASE}/lib
> CFLAGS += -I${X11BASE}/include -I${LOCALBASE}/include
>
> -DEBUG_CONFIGURE_ARGS = -DCMAKE_BUILD_TYPE=Debug
> DEBUG_PACKAGES = ${BUILD_PACKAGES}
>
> NO_TEST = Yes
>
> -MODCMAKE_LDFLAGS = -L${X11BASE}/lib -L${LOCALBASE}/lib
> WRKSRC = ${WRKDIST}/prboom2
>
> post-install:
