On Wed, Jul 19, 2023 at 06:33:52PM -0300, Lucas de Sena wrote:
> DSDA-Doom is a new doom source port.
>
> The port is building fine here with the patch I added.
>
> Ok?
A few comments/requests:
1. There are dependencies/WANTLIBS missing:
$ make port-lib-depends-check
dsda-doom-0.26.2(games/dsda-doom):
Missing: c++.9 (/usr/local/bin/dsda-doom) (system lib)
Missing: c++abi.6 (/usr/local/bin/dsda-doom) (system lib)
Missing lib: mad.2 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing: ogg.6 from libogg-1.3.5 (/usr/local/bin/dsda-doom)
Missing lib: portmidi.0 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing lib: vorbis.9 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing lib: vorbisfile.6 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing: z.7 (/usr/local/bin/dsda-doom) (system lib)
Missing lib: zip.4 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
WANTLIB += ${COMPILER_LIBCXX} ogg z
2. I would prefer to make the use of tabs more uniform in Makefile, as
in that they start the values at about the same tab marker.
3. What is the value of disabling fluidsynth in the Makefile? We have
it in ports...
